On Tue, Mar 19, 2024 at 04:06:28PM -0700, Christoph Hellwig wrote: > Is there much of a good reason to do this now vs oing it whenverer > we actually sort out i_version semantics? It adds size to the inode > and I don't see how the atomics actually cost us much. The patch > itself does looks good, though. I /think/ it's safe because all the callers I found gated their inode*inc_iversion calls on IS_I_VERSION(), but as di_changecount is now a totally internal inode attribute, I don't think it should be out where the VFS can mess with it. --D