On Tue, Mar 19, 2024 at 02:41:27PM -0700, Christoph Hellwig wrote: > On Tue, Mar 19, 2024 at 02:38:27PM -0700, Darrick J. Wong wrote: > > 64k is the maximum xattr value size, yes. But remote xattr value blocks > > now have block headers complete with owner/uuid/magic/etc. Each block > > can only store $blksz-56 bytes now. Hence that 64k value needs > > ceil(65536 / 4040) == 17 blocks on a 4k fsb filesystem. > > Uggg, ok. I thought we'd just treat remote xattrs as data and don't > add headers. We needed CRCs for them, and they can be discontiguous so we also needed self identifying information so xattrs could be reconstructed from the header information. If I was doing the v5 stuff again, I would have put a the information in the remote xattr name structure held in the dabtree record, not the actual xattr data extent. But hindsight is 20:20.... -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
