On Thu, Oct 19, 2023 at 01:09:13PM -0700, Darrick J. Wong wrote: > permit reads, since the source file contents do not change. This is a duplicate white space before "not" > +#ifndef FICLONE > +# define FICLONE _IOW(0x94, 9, int) > +#endif Can't we assume system headers with FICLONE by now? > +# real QA test starts here > +_require_scratch_reflink This needs a _require_scratch before the _require_scratch_reflink. Otherwise this looks good to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
