On Thu, Oct 19, 2023 at 11:09:49PM -0700, Christoph Hellwig wrote: > On Thu, Oct 19, 2023 at 01:09:13PM -0700, Darrick J. Wong wrote: > > permit reads, since the source file contents do not change. This is a > > duplicate white space before "not" Fixed. > > +#ifndef FICLONE > > +# define FICLONE _IOW(0x94, 9, int) > > +#endif > > Can't we assume system headers with FICLONE by now? That depends on the long tail of RHEL7. But you're right, it has been years now, I'll just kill this hunk and see who complains. :) > > +# real QA test starts here > > +_require_scratch_reflink > > This needs a _require_scratch before the _require_scratch_reflink. Ok, will do. > Otherwise this looks good to me: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! --D
