Re: [PATCH 1/4] xfs: create a helper to handle logging parts of rt bitmap/summary blocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 19, 2023 at 09:27:48AM -0700, Darrick J. Wong wrote:
> +	size_t			first, last;
> +
> +	first = (void *)xfs_rsumblock_infoptr(bp, infoword) - bp->b_addr;
> +	last = first + sizeof(xfs_suminfo_t) - 1;

> +	size_t			first, last;
> +
> +	first = (void *)xfs_rbmblock_wordptr(bp, from) - bp->b_addr;
> +	last = ((void *)xfs_rbmblock_wordptr(bp, next) - 1) - bp->b_addr;
> +
> +	xfs_trans_log_buf(tp, bp, first, last);

Going to pointers and back looks a bit confusing and rather inefficient
to me.  But given how late we are in the cycle I don't want to derail
your series, so let's keep this as-is for now, and I'll add a TODO
list item to my ever growing list to eventually lean this up.




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux