On Thu, Oct 19, 2023 at 09:27:48AM -0700, Darrick J. Wong wrote: > + size_t first, last; > + > + first = (void *)xfs_rsumblock_infoptr(bp, infoword) - bp->b_addr; > + last = first + sizeof(xfs_suminfo_t) - 1; > + size_t first, last; > + > + first = (void *)xfs_rbmblock_wordptr(bp, from) - bp->b_addr; > + last = ((void *)xfs_rbmblock_wordptr(bp, next) - 1) - bp->b_addr; > + > + xfs_trans_log_buf(tp, bp, first, last); Going to pointers and back looks a bit confusing and rather inefficient to me. But given how late we are in the cycle I don't want to derail your series, so let's keep this as-is for now, and I'll add a TODO list item to my ever growing list to eventually lean this up.
