First a note: the explanations in this email thread were really
helpful understanding the patch. Can you make sure they are
recorded in the next version of the commit message?
Otherwise just some nitpicks:
> -xfs_lsn_t
> -xlog_grant_push_threshold(
> - struct xlog *log,
> - int need_bytes)
This is moved around and reappears as xfs_ail_push_target. Maybe
split the move, rename and drop of the need_bytes into a separate
cleanup patch after this main one.
> +int xlog_space_left(struct xlog *log, atomic64_t *head);
Odd indentation with the tab before *log here.
> +xfs_lsn_t __xfs_ail_push_target(struct xfs_ail *ailp);
> +static inline xfs_lsn_t xfs_ail_push_target(struct xfs_ail *ailp)
> +{
> + xfs_lsn_t lsn;
> +
> + spin_lock(&ailp->ail_lock);
> + lsn = __xfs_ail_push_target(ailp);
> + spin_unlock(&ailp->ail_lock);
> + return lsn;
> +}
Before this patch xfs_defer_relog called xlog_grant_push_threshold
without the ail_lock, why is ail_lock needed now?
