> __xfs_ail_push_target(
> struct xfs_ail *ailp)
> {
> + struct xlog *log = ailp->ail_log;
> + struct xfs_log_item *lip;
>
> + xfs_lsn_t target_lsn = 0;
Any reason for the empty line and different indentation here?
> + xfs_lsn_t max_lsn;
> + xfs_lsn_t min_lsn;
> + int32_t free_bytes;
> + uint32_t target_block;
> + uint32_t target_cycle;
> +
> + lockdep_assert_held(&ailp->ail_lock);
> +
> + lip = xfs_ail_max(ailp);
> + if (!lip)
> + return NULLCOMMITLSN;
> + max_lsn = lip->li_lsn;
> + min_lsn = __xfs_ail_min_lsn(ailp);
Ok, this appears to be when we actually need the ail_lock added in the
previous patch.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
