Re: [PATCH 2/9] xfs: AIL doesn't need manual pushing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, Sep 07, 2022 at 07:01:11AM -0700, Christoph Hellwig wrote:
> > +static inline xfs_lsn_t xfs_ail_push_target(struct xfs_ail *ailp)
> > +{
> > +	xfs_lsn_t	lsn;
> > +
> > +	spin_lock(&ailp->ail_lock);
> > +	lsn = __xfs_ail_push_target(ailp);
> > +	spin_unlock(&ailp->ail_lock);
> > +	return lsn;
> > +}
> Before this patch xfs_defer_relog called xlog_grant_push_threshold
> without the ail_lock, why is ail_lock needed now?

Looking through the most recent version of the patch this is still
there and I'm also not seeing an explanation in the patch.  Can
you comment on this change in the commit log?

I also still find it not very helpful that xlog_grant_push_threshold
gets moved and renamed as part of a huge behavior change patch.

The rest still looks good to me even in the last version.

[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]

  Powered by Linux