On Tue, Nov 02, 2021 at 08:24:14PM +0000, Matthew Wilcox wrote: > On Tue, Nov 02, 2021 at 12:13:22AM -0700, Christoph Hellwig wrote: > > On Mon, Nov 01, 2021 at 08:39:11PM +0000, Matthew Wilcox (Oracle) wrote: > > > +static inline > > > +void bio_first_folio(struct folio_iter *fi, struct bio *bio, int i) > > > > Please fix the weird prototype formatting here. > > I dunno, it looks weirder this way: > > -static inline > -void bio_first_folio(struct folio_iter *fi, struct bio *bio, int i) > +static inline void bio_first_folio(struct folio_iter *fi, struct bio *bio, > + int i) > > Anyway, I've made that change, but I still prefer it the way I had it. I /think/ Christoph meant: static inline void bio_first_folio(...) Though the form that you've changed it to is also fine. --D > > Otherwise looks good: > > > > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
