Re: [PATCH 03/21] block: Add bio_for_each_folio_all()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 03/21] block: Add bio_for_each_folio_all()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 2 Nov 2021 00:13:22 -0700
Cc: "Darrick J. Wong" <djwong@xxxxxxxxxx>, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Jens Axboe <axboe@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to: <20211101203929.954622-4-willy@infradead.org>
References: <20211101203929.954622-1-willy@infradead.org> <20211101203929.954622-4-willy@infradead.org>

On Mon, Nov 01, 2021 at 08:39:11PM +0000, Matthew Wilcox (Oracle) wrote:
> +static inline
> +void bio_first_folio(struct folio_iter *fi, struct bio *bio, int i)

Please fix the weird prototype formatting here.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Follow-Ups:
- Re: [PATCH 03/21] block: Add bio_for_each_folio_all()
  - From: Matthew Wilcox

References:
- [PATCH 00/21] iomap/xfs folio patches
  - From: Matthew Wilcox (Oracle)
- [PATCH 03/21] block: Add bio_for_each_folio_all()
  - From: Matthew Wilcox (Oracle)

Prev by Date: Re: [PATCH 02/21] block: Add bio_add_folio()
Next by Date: Re: [PATCH 04/21] iomap: Convert to_iomap_page to take a folio
Previous by thread: Re: [PATCH 03/21] block: Add bio_for_each_folio_all()
Next by thread: Re: [PATCH 03/21] block: Add bio_for_each_folio_all()
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]

Powered by Linux