> +/* Check that a file block offset does not exceed the maximum. */ > +bool > +xfs_verify_fileoff( > + struct xfs_mount *mp, > + xfs_fileoff_t off) > +{ > + return off <= XFS_MAX_FILEOFF; > +} I think an inline function would make sense here.. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>