On Wed, Jul 22, 2020 at 11:05:18AM +0200, Carlos Maiolino wrote: > Every call to xfs_da_state_alloc() also requires setting up state->args > and state->mp > > Change xfs_da_state_alloc() to receive an xfs_da_args_t as argument and > return a xfs_da_state_t with both args and mp already set. I would have not use the typedef versions and switched to the raw struct type, but that's something we should eventually take care of with a bulk cleanup anyway, so: Reviewed-by: Christoph Hellwig <hch@xxxxxx>