On Wed, Jul 22, 2020 at 11:05:14AM +0200, Carlos Maiolino wrote: > - /* > - * if this didn't occur in transactions, we could use > - * KM_MAYFAIL and return NULL here on ENOMEM. Set the > - * code up to do this anyway. > - */ > - ip = kmem_zone_alloc(xfs_inode_zone, 0); > - if (!ip) > - return NULL; > + ip = kmem_cache_alloc(xfs_inode_zone, GFP_KERNEL | __GFP_NOFAIL); > + I would have kept a version of this comment. But if this on your radar for the next merge window anyway this should be ok: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
