On Wed, Jul 22, 2020 at 11:05:18AM +0200, Carlos Maiolino wrote:
> Every call to xfs_da_state_alloc() also requires setting up state->args
> and state->mp
>
> Change xfs_da_state_alloc() to receive an xfs_da_args_t as argument and
> return a xfs_da_state_t with both args and mp already set.
>
> Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
> ---
>
> Changelog:
> V3:
> - Originally this patch removed xfs_da_state_alloc(),
> per hch's suggestion, instead of removing, it has been
> refactored, to also set state->{args,mp} which removes
> a few lines of code.
>
> fs/xfs/libxfs/xfs_attr.c | 17 +++++------------
> fs/xfs/libxfs/xfs_da_btree.c | 8 ++++++--
> fs/xfs/libxfs/xfs_da_btree.h | 2 +-
> fs/xfs/libxfs/xfs_dir2_node.c | 17 +++++------------
> fs/xfs/scrub/dabtree.c | 4 +---
> 5 files changed, 18 insertions(+), 30 deletions(-)
With the typedefs fixed,
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
--
Dave Chinner
david@xxxxxxxxxxxxx
