On Sun, May 10, 2020 at 09:09:14AM -0500, Eric Sandeen wrote: > On 5/10/20 2:11 AM, Christoph Hellwig wrote: > > On Sat, May 09, 2020 at 12:23:42PM -0500, Eric Sandeen wrote: > >> On 5/9/20 12:01 PM, Christoph Hellwig wrote: > >>> Don't use local variables for information that is set in the da_args > >>> structure. > >> > >> I'm on the fence about this one; Darrick had missed setting a couple > >> of necessary structure members, so I actually see some value in assigning them > >> all right before we call into libxfs_attr_set .... it makes it very clear what's > >> being sent in to libxfs_attr_set. > > > > But using additional local variables doesn't help with initialing > > the fields, it actually makes it easier to miss, which I guess is > > what happened. I find the code much easier to verify without the > > extra variables. > > They seem a bit extraneous, but my problem is I can't keep track of how much > of the args structure is actually filled out when it's spread out over dozens > of lines .... > > *shrug* I dunno. Maybe darrick can cast the tie-breaking vote. ;) I mean... I /did/ already RVB this one... :) --D
