On Sunday 10 May 2020 12:53:59 PM IST Christoph Hellwig wrote: > XFS_IFORK_Q is to be used in boolean context, not for a size. This > doesn't make a difference in practice as size is only checked for > 0, but this keeps the logic sane. > Wouldn't XFS_IFORK_ASIZE() be a better fit since it gives the space used by the attr fork inside an inode's literal area? > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- > fs/xfs/scrub/bmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/scrub/bmap.c b/fs/xfs/scrub/bmap.c > index add8598eacd5d..283424d6d2bb6 100644 > --- a/fs/xfs/scrub/bmap.c > +++ b/fs/xfs/scrub/bmap.c > @@ -591,7 +591,7 @@ xchk_bmap_check_rmaps( > size = i_size_read(VFS_I(sc->ip)); > break; > case XFS_ATTR_FORK: > - size = XFS_IFORK_Q(sc->ip); > + size = XFS_IFORK_BOFF(sc->ip); > break; > default: > size = 0; > -- chandan
