On Sat, May 09, 2020 at 12:23:42PM -0500, Eric Sandeen wrote: > On 5/9/20 12:01 PM, Christoph Hellwig wrote: > > Don't use local variables for information that is set in the da_args > > structure. > > I'm on the fence about this one; Darrick had missed setting a couple > of necessary structure members, so I actually see some value in assigning them > all right before we call into libxfs_attr_set .... it makes it very clear what's > being sent in to libxfs_attr_set. But using additional local variables doesn't help with initialing the fields, it actually makes it easier to miss, which I guess is what happened. I find the code much easier to verify without the extra variables.
