Re: [PATCH 09/21] xfs: refactor log recovery EFI item dispatch for pass2 commit functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 01, 2020 at 03:28:44AM -0700, Christoph Hellwig wrote:
> > +STATIC int
> > +xlog_recover_extfree_done_commit_pass2(
> > +	struct xlog			*log,
> > +	struct list_head		*buffer_list,
> > +	struct xlog_recover_item	*item,
> > +	xfs_lsn_t			lsn)
> > +{
> 
> ...
> 
> > +	return 0;
> > +}
> > +
> >  const struct xlog_recover_item_type xlog_extfree_intent_item_type = {
> > +	.commit_pass2_fn	= xlog_recover_extfree_intent_commit_pass2,
> >  };
> >  
> >  const struct xlog_recover_item_type xlog_extfree_done_item_type = {
> > +	.commit_pass2_fn	= xlog_recover_extfree_done_commit_pass2,
> >  };
> 
> Nipick: It would be nice to keep all the efi vs efd code together
> with their ops vectors?  Same for the other intent ops.

Ok, will do.

--D



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux