> +STATIC int > +xlog_recover_extfree_done_commit_pass2( > + struct xlog *log, > + struct list_head *buffer_list, > + struct xlog_recover_item *item, > + xfs_lsn_t lsn) > +{ ... > + return 0; > +} > + > const struct xlog_recover_item_type xlog_extfree_intent_item_type = { > + .commit_pass2_fn = xlog_recover_extfree_intent_commit_pass2, > }; > > const struct xlog_recover_item_type xlog_extfree_done_item_type = { > + .commit_pass2_fn = xlog_recover_extfree_done_commit_pass2, > }; Nipick: It would be nice to keep all the efi vs efd code together with their ops vectors? Same for the other intent ops.