On Fri, May 01, 2020 at 03:19:47AM -0700, Christoph Hellwig wrote: > On Wed, Apr 29, 2020 at 05:48:59PM -0700, Darrick J. Wong wrote: > > +STATIC int xfs_efi_recover(struct xfs_mount *mp, struct xfs_efi_log_item *efip); > > Can you just move xfs_efi_item_ops down a bit to avoid the forward > declaration? Same for the other patches doing the same. I can, but then I need a forward declaration of xfs_efi_item_ops, because xfs_efi_init needs the symbol, and the ->create_intent function inside the item_ops needs xfs_efi_init. Still, a forward declaration of a static variable is easier to maintain than a function decl, so I'll change it. --D
