On Wed, Apr 29, 2020 at 05:48:59PM -0700, Darrick J. Wong wrote: > +STATIC int xfs_efi_recover(struct xfs_mount *mp, struct xfs_efi_log_item *efip); Can you just move xfs_efi_item_ops down a bit to avoid the forward declaration? Same for the other patches doing the same.