On Wed, Jun 26, 2019 at 07:57:32AM +0200, Christoph Hellwig wrote: > On Tue, Jun 25, 2019 at 10:57:01PM -0700, Darrick J. Wong wrote: > > That may be, but I don't want to merge this patchset only to find out > > I've unleashed Pandora's box of untested cgroupwb hell... I /think/ they > > fixed all those problems, but it didn't take all that long tracing the > > blkg/blkcg object relationships for my brain to fall out. :/ > > c'mon. We are adding handful of line patch to finally bring XFS in > line with everyone else. That doesn't mean we want to take over > cgroup maintenance. I didn't want us to take over maintenance of copy_file_range and the remap ioctls either, but now look. /me burns out on cleaning up new features that haven't been adequately specified and tested and having to retrofit sane behavior into existing userspace ABI; and I wouldn't be shocked to hear Dave and Amir probably feel similarly. <frown> That said, I did go digging further into how cgroup writeback accounting works and AFAICT the things people were complaining about in the last three attempts to add cgroupwb support to xfs have been solved, so I guess I'm fine with the series: Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D
