On Wed, May 15, 2019 at 12:52:53AM -0700, Christoph Hellwig wrote: > On Mon, May 13, 2019 at 11:44:34AM -0400, Brian Foster wrote: > > The only functional change was basically to check for ccur before using > > it and initializing i to zero. It just seemed to make sense to clean up > > the surrounding code while there, but I can either split out the > > aesthetic cleanup or defer that stuff to the broader rework at the end > > of the series (where the cursor stuff just gets ripped out anyways) if > > either of those is cleaner.. > > Yeah, I noticed how trivial the actual change was. That is why just > doing the cleanup in pass 1 and applying the change in pass 2 might > make it more readbale. It might also be worth to throw in the use > a goto label instead of long conditionals from your last patch into > that cleanup prep patch. Ok, I've lifted all of the small mode refactoring (from both this patch and the last one) into an initial patch. Unless you indicate otherwise, I've also retained your review tag(s), though you might want to take a cursory look once the next version lands. Brian
