On Fri, May 10, 2019 at 10:24:46AM -0700, Christoph Hellwig wrote: > This looks pretty sensible to me. What confuses me a bit is that > the patch is much more (good!) refactoring than the actual change. > > If you have to respin it maybe split it up, making the actual > behavior change even more obvious. > The only functional change was basically to check for ccur before using it and initializing i to zero. It just seemed to make sense to clean up the surrounding code while there, but I can either split out the aesthetic cleanup or defer that stuff to the broader rework at the end of the series (where the cursor stuff just gets ripped out anyways) if either of those is cleaner.. Brian > Otherwise: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
