This looks pretty sensible to me. What confuses me a bit is that the patch is much more (good!) refactoring than the actual change. If you have to respin it maybe split it up, making the actual behavior change even more obvious. Otherwise: Reviewed-by: Christoph Hellwig <hch@xxxxxx>