On Tue, Nov 13, 2018 at 04:26:51PM +1100, Dave Chinner wrote: > That's just as bad as removing them all, if not worse. > > If you are writing new code or reworking existing code, then we'll > consider the usage of STATIC/static in the context of that work. > Otherwise, we leave it alone. > > It if ain't broke, don't fix it. And it sure as hell isn't broken > right now. We've got more than enough bugs to fix without having to > deal with drive-by bikeshed painting... Agreed. That being said I think we should aim to add manual noline annotations to those functions where we really care while we go through the code instead of the weird STATIC that just seems to cause this kind of confusion. And if Joe or somone else can come up with a few patches where removing the noinline (aka STATIC) makes a huge difference for a small number of functions we should consider it as well.
