On Tue, Nov 13, 2018 at 12:08:19PM -0500, Brian Foster wrote: > diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c > index ecdb086bc23e..c56bdbfcf7ae 100644 > --- a/fs/xfs/xfs_reflink.c > +++ b/fs/xfs/xfs_reflink.c > @@ -296,6 +296,7 @@ xfs_reflink_reserve_cow( > if (error) > return error; > > + xfs_trim_extent(imap, got.br_startoff, got.br_blockcount); > trace_xfs_reflink_cow_alloc(ip, &got); > return 0; It would be kinda nice to have a comment explaining this trimming, and a goto label to share it with the case where we find existing delalloc reservations. That being said my always_cow series totally reshuffles this area, so it might not be worth to spend the effort here, so: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
