On Mon, Jul 23, 2018 at 09:04:12AM -0400, Brian Foster wrote: > Each xfs_defer_init() call in the xattr code uses the internal dfops > reference. In addition, a successful xfs_defer_finish() always > returns with a reset xfs_defer_ops structure. > > Given that along with the fact that every xfs_defer_init() call in > the xattr code is followed up by an xfs_defer_finish(), the former > calls are no longer necessary and can be removed. > > Note that the xfs_defer_init() call in the remote value copy loop of > xfs_attr_rmtval_set() is not followed by a finish, but the dfops is > unused in this instance. > > Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
