On Mon, Jul 23, 2018 at 09:04:11AM -0400, Brian Foster wrote: > At this point, the transaction subsystem completely manages deferred > items internally such that the common and boilerplate > xfs_trans_alloc() -> xfs_defer_init() -> xfs_defer_finish() -> > xfs_trans_commit() sequence can be replaced with a simple > transaction allocation and commit. > > Remove all such boilerplate deferred ops code. In doing so, we > change each case over to use the dfops in the transaction and > specifically eliminate: > > - The on-stack dfops and associated xfs_defer_init() call, as the > internal dfops is initialized on transaction allocation. > - xfs_bmap_finish() calls that precede a final xfs_trans_commit() of > a transaction. > - xfs_defer_cancel() calls in error handlers that precede a > transaction cancel. > > The only deferred ops calls that remain are those that are > non-deterministic with respect to the final commit of the associated > transaction or are open-coded due to special handling. > > Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx> Nice! Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
