> -int xfs_defer_finish(struct xfs_trans **tp, struct xfs_defer_ops *dop); > -void xfs_defer_cancel(struct xfs_defer_ops *dop); > +int xfs_defer_finish(struct xfs_trans **tp); > +void __xfs_defer_cancel(struct xfs_defer_ops *dop); > index dc79e3c1d3e8..5170e89bec02 100644 > --- a/fs/xfs/xfs_trans.h > +++ b/fs/xfs/xfs_trans.h > @@ -214,6 +214,9 @@ xfs_trans_read_buf( > flags, bpp, ops); > } > > +/* cancel dfops associated with a transaction */ > +void xfs_defer_cancel(struct xfs_trans *); Is there any good reason not to keep xfs_defer_cancel in xfs_defer.[ch]? Otherwise this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html