Re: [PATCH 3/6] xfs: pass individual arguments to xfs_bmap_add_extent_hole_real

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 10, 2017 at 10:13:16AM -0700, Darrick J. Wong wrote:
> > -	struct xfs_bmalloca	*bma,
> > -	int			whichfork)
> > +	struct xfs_trans	*tp,
> > +	xfs_inode_t		*ip,	/* incore inode pointer */
> > +	int			whichfork,
> > +	xfs_extnum_t		*idx,	/* extent number to update/insert */
> > +	xfs_btree_cur_t		**curp,	/* if *curp is null, not a btree */
> > +	xfs_bmbt_irec_t		*new,	/* new data to add to file extents */
> 
> struct xfs_inode vs. xfs_inode_t ?

Sure, I can fix this up.

> 
> I was under the impression that we don't add comments to the function
> arguments anymore, but TBH they don't bother me.

It's copy and paste from the other function in the family that
takes individual parameters.  I can remove it.
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux