On Mon, Apr 10, 2017 at 10:05:39AM -0700, Darrick J. Wong wrote: > Hmmmm. We never schedule deferred bmap operations for the attr fork, > but all that stuff got plumbed all the way through to the bmap log item > that is written to disk. Therefore, it's possible that we may some day > replay a log from a future XFS with a deferred attr fork bmap item in > the log, at which point log recovery blows up here. If we add that it's a format change that needs a incompat feature flag. > I wonder if this might be worth a WARN_ON_ONCE just to make it obvious > that recovery stopped because it doesn't handle deferred attr fork bmap > updates? Sure, although we should never actually hit it. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html