On Mon, Oct 17, 2016 at 02:05:18PM +0200, Christoph Hellwig wrote: > The VFS i_ino is an unsigned long, while XFS inode numbers are 64-bit > wide, so checking i_ino for equality could lead to rate false positives > on 32-bit architectures. Just compare the inode pointers themselves > to be safe. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > fs/xfs/xfs_file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index 20563f2..012a960 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -1003,7 +1003,7 @@ xfs_file_share_range( > IS_SWAPFILE(inode_out)) > return -ETXTBSY; > > - same_inode = (inode_in->i_ino == inode_out->i_ino); > + same_inode = (inode_in == inode_out); > > /* Don't reflink dirs, pipes, sockets... */ > if (S_ISDIR(inode_in->i_mode) || S_ISDIR(inode_out->i_mode)) > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
