Re: [PATCH 45/63] xfs: unshare a range of blocks via fallocate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 27, 2016 at 07:58:25PM -0700, Darrick J. Wong wrote:
> Now that we have an fallocate flag to unshare a range of blocks, make
> XFS actually implement it.

There is unshared flag in here.  Instead it performs an unshare
without passing any flag, which will break existing users of fallocate
like the NFS server.

> v2: NFS doesn't pass around struct file pointers, which means that our
> unshare functions all crash when filp == NULL.  We don't need filp
> anyway, so remove all the parts where we pass filp around.

NFSD passes a file pointer just fine.  Note that it really should
matter, but this comment confused me.
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux