Re: [PATCH v9 00/63] xfs: add reflink and dedupe support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 29, 2016 at 06:46:31AM -0700, Christoph Hellwig wrote:
> Your tree only compiles with a few new warnings for me:
> 
> fs/xfs/xfs_reflink.c: In function ‘xfs_reflink_recover_cow_ag’:
> fs/xfs/xfs_reflink.c:839:8: warning: missing braces around initializer
> [-Wmissing-braces]
>   union xfs_btree_irec  low = {0};
>         ^
> s/xfs/xfs_reflink.c:839:8: warning: (near initialization for
> ‘low.a’) [-Wmissing-braces]
> fs/xfs/xfs_reflink.c:840:8: warning: missing braces around initializer
> [-Wmissing-braces]
>   union xfs_btree_irec  high = {0};
>         ^
> fs/xfs/xfs_reflink.c:840:8: warning: (near initialization for
> ‘high.a’) [-Wmissing-braces]

Hmm, now you're the second person to complain about this.  Evidently
gcc 5.4 doesn't care about this, but older versions (Dave said 4.9.3
also spat these warnings) do care.  Will push out fix.

--D
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux