On Thu, Sep 29, 2016 at 10:07:59AM -0700, Christoph Hellwig wrote: > On Tue, Sep 27, 2016 at 07:58:25PM -0700, Darrick J. Wong wrote: > > Now that we have an fallocate flag to unshare a range of blocks, make > > XFS actually implement it. > > There is [no] unshared flag in here. Drat! I totally forgot to add the unshare flag back in! We even had a whole email thread about this months ago. :( :( Ok, I'll put in a flag. > Instead it performs an unshare without passing any flag, which will break > existing users of fallocate like the NFS server. > > v2: NFS doesn't pass around struct file pointers, which means that our > > unshare functions all crash when filp == NULL. We don't need filp > > anyway, so remove all the parts where we pass filp around. > > NFSD passes a file pointer just fine. Note that it really should > matter, but this comment confused me. Yeah, it confused me as well, so I'll just go back to your original changelog message. --D -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
