Hello Jakub.
On 31.08.22 20:21, Jakub Kicinski wrote:
On Tue, 30 Aug 2022 23:31:24 -0700 Jakub Kicinski wrote:
Hm, let me add 802154 folks.
Either we should treat the commands as reserved in terms of uAPI
even if they get removed the IDs won't be reused, or they are for
testing purposes only.
In the former case we should just remove the #ifdef around the values
in the enum, it just leads to #ifdef proliferation while having no
functional impact.
In the latter case we should start error checking from the last
non-experimental command, as we don't care about breaking the
experimental ones.
I haven't gone thru all of my inbox yet, but I see no reply from Stefan
or Alexander. My vote is to un-hide the EXPERIMENTAL commands.
I was swamped today and I am only now finding time to go through mail.
Given the problem these ifdef are raising I am ok with having these
commands exposed without them.
Our main reason for having this feature marked as experimental is that
it does not have much exposure and we fear that some of it needs rewrites.
If that really is going to happen we will simply treat the current
commands as reserved/burned and come up with other ones if needed. While
I hope this will not be needed it is a fair plan for mitigating this.
regards
Stefan Schmidt
