Search Linux Wireless

Re: [PATCH/RFC] rfkill: prevent unnecessary event generation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2012-09-22 at 21:37 +0200, Vitaly Wool wrote:
> Hi Johannes,
> 
> On Fri, Sep 7, 2012 at 3:04 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> > On Fri, 2012-09-07 at 15:02 +0200, Vitaly Wool wrote:
> >
> >> >> I'm not sure I got your question, but just in case, rfkill is
> >> >> initialized to all zeroes so rfkill->state is 0 and on each consequent
> >> >> _real_ change there (prev != curr) == true and the event will be
> >> >> generated.
> >> >
> >> > But maybe applications were expecting an event for registration? Or do
> >> > we get that anyway maybe?
> >>
> >> We should get them anyway. rfkill_fop_open() basically just pushes all
> >> the startup events into the list so the application will see all the
> >> _changes_ on registration. And at least wpa_supplicant reads out all
> >> these events on rfkill registration. If an application does something
> >> else, then I think it's buggy.
> >
> > Aha, good point. I guess I'll apply the patch then :)
> 
> provided that I don't see the patch merged, is there anything else we
> should take care of before it's considered good enough?

No, my mistake ... applied now.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux