On Thu, 2012-08-23 at 18:54 +0300, Vladimir Kondratiev wrote: > > > + * @NL80211_ATTR_4WAY_HANDSHAKE_OFFLOAD_AP: This is a flag that indicates > > > to + * WPA supplicant that 4-way handshake has been offloaded to the > > > firmware + * in the AP mode. > > > + * In this case, WPA supplicant will provide driver with PSK for > > > + * start_ap() > > > > I think you should use the nl80211 driver flags, not extra attributes > > here. > > I thought I need to use same approach as for other flags. All other use bit in > wiphy.flags and NL80211_ATTR_xxx. And reason is simple - in the NL80211, it is > enum, while for the driver one need to reserve a bit. This is how other flags > are dealt with: > > if ((dev->wiphy.flags & WIPHY_FLAG_IBSS_RSN) && > nla_put_flag(msg, NL80211_ATTR_SUPPORT_IBSS_RSN)) > goto nla_put_failure; Yes, but we abandoned this approach later, in favour of the nl80211 feature flags. > I want to do some more work exploring how this offload serves in real life, > will submit when (if?) it will be ready. Ok, sounds good! johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
