On Thu, 2012-08-02 at 14:33 +0300, Vladimir Kondratiev wrote:
> + * @NL80211_ATTR_4WAY_HANDSHAKE_OFFLOAD_STA: This is a flag that indicates to
> + * WPA supplicant that 4-way handshake has been offloaded to the firmware
> + * in the STA mode.
> + * In this case, WPA supplicant will provide driver with PSK for
> + * connect()
> + *
> + * @NL80211_ATTR_4WAY_HANDSHAKE_OFFLOAD_AP: This is a flag that indicates to
> + * WPA supplicant that 4-way handshake has been offloaded to the firmware
> + * in the AP mode.
> + * In this case, WPA supplicant will provide driver with PSK for
> + * start_ap()
I think you should use the nl80211 driver flags, not extra attributes
here.
> struct cfg80211_connect_params {
> struct ieee80211_channel *channel;
> @@ -1322,6 +1325,7 @@ struct cfg80211_connect_params {
> int bg_scan_period;
> struct ieee80211_ht_cap ht_capa;
> struct ieee80211_ht_cap ht_capa_mask;
> + const u8 *psk;
> };
And the descriptions (and flag checking!) should make it clear that it
is only supported with the connect() API, not with the auth/assoc APIs.
> + * @WIPHY_FLAG_4WAY_HANDSHAKE_OFFLOAD: Device supports 4-way handshake offload.
Use nl80211 flag directly. Also, docs are wrong:
> + WIPHY_FLAG_4WAY_HANDSHAKE_OFFLOAD_STA = BIT(22),
> + WIPHY_FLAG_4WAY_HANDSHAKE_OFFLOAD_AP = BIT(23),
Please also add validation that these flags are specified only when the
correct APIs (connect/start_ap) are supported.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
