On Sun, Jul 8, 2012 at 12:35 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > So the subject is wrong since "&priv->conf.phy" can hardly be "static > global", but Yea you're right. The static global pointer was used before, now it's a different location we copy stuff into. > >> We get DMA alignment trouble if the beginning of the struct is >> unaligned. Allocate memory and send it to FW. > > If this is all about alignment, and > >> + params = kzalloc(sizeof(*params), GFP_KERNEL); > > kzalloc (which is pointless -- use kmemdup) alignment is sufficient, > then most likely you could just put "__aligned(4)" or something on the > conf.phy struct member and not allocate memory at all? Yea we need 4 bytes alignment. The kzalloc is a sort of convention in the driver (see acx.c), but probably here we can use kmemdup. We can't use fancy __aligned(4) notations most likely, since a usermode tool also parses these header files, and it's not too smart :) Anyway I'll fix the subject and use kmemdup. Thanks for the review. Arik -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
