On Sun, 2012-07-08 at 11:35 +0200, Johannes Berg wrote: > So the subject is wrong since "&priv->conf.phy" can hardly be "static > global", but > > > We get DMA alignment trouble if the beginning of the struct is > > unaligned. Allocate memory and send it to FW. > > If this is all about alignment, and > > > + params = kzalloc(sizeof(*params), GFP_KERNEL); > > kzalloc (which is pointless -- use kmemdup) alignment is sufficient, > then most likely you could just put "__aligned(4)" or something on the > conf.phy struct member and not allocate memory at all? I'll leave this one out for now until Arik has the time to look into it. Thanks for your comments, Johannes! -- Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html