On Sun, 2012-07-08 at 17:08 +0300, Arik Nemtsov wrote: > > kzalloc (which is pointless -- use kmemdup) alignment is sufficient, > > then most likely you could just put "__aligned(4)" or something on the > > conf.phy struct member and not allocate memory at all? > > Yea we need 4 bytes alignment. The kzalloc is a sort of convention in > the driver (see acx.c), but probably here we can use kmemdup. > We can't use fancy __aligned(4) notations most likely, since a > usermode tool also parses these header files, and it's not too smart > :) This seems like a rather bad excuse for making the runtime code more complex and less performant ... I'll let you sort it out with John though, I wouldn't let you get away with this though if I maintained the tree ;-) FWIW, I think your actual problem is that you mark wl18xx_priv_conf as packed unnecessarily. Otherwise it might actually get alignment, at least on ARM I hear. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
