On Fri, Jul 6, 2012 at 8:51 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Fri, 2012-07-06 at 08:47 -0700, Luis R. Rodriguez wrote: > >> > I guess the question is -- what does that code really enable, if the >> > driver doesn't also set the feature flag? If it doesn't mean anything >> > without the flag I think we don't need the extra core option? >> >> Ah -- good question. It'd just be the core. The core can support the >> base station hint or not but apart from the core we could technically >> also have a scenario today where perhaps one 802.11 card does support >> the station hint another does not. It is true that with no 802.11 card >> present having the core makes no sense but in practice we would, or at >> the very least we'd have the mac80211_hwsim. >> >> So as I designed this I realized we really did have to consider the >> core getting this Vs a card getting this hint. The core getting the >> hint would only happen as-is with the onus option enabled, so if we >> want the onus option only to be a gate to other options then >> technically the feature would be for the core, while drivers would >> have the options to enable / disable the same feature given that this >> requires testing / maybe some changes in the firmware. > > I'm not sure I really understand what you're saying :-) > > What I really wanted to know though is this: If the core code is > enabled, what effect does receiving a "blessed" hint have on devices > that don't set the flag? If there's no effect vs. an "unblessed" hint, > then I think we don't need another option? Ah, OK so yes, as it is right now if the core accepts the hint but devices do not listen to it we do have an effect right now which I alluded to in my cover letter: country IE hints won't be listened to after a base station hint gets accepted. Whether or not we want to process country IE hints *after* a cell base station hint gets accepted is debatable -- I decided that its easier to implement to ignore country IE hints after a cell base station hint and I also decided cell base station hints are likely something you'd prefer to review over country IE hints. We can certainly change this and I'm open to it. So yes, as it is right now if you enable onus but your device does not support he feature you may detect a regression: country IE hints would not be processed if you did receive a base station hint that the core processed. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
