On Fri, Jul 6, 2012 at 7:11 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Fri, 2012-07-06 at 07:05 -0700, Luis R. Rodriguez wrote: > >> That, but also it means there are two hops for a device to use the >> cell base station hint: onus option, and then the feature flag, which >> could be wrapped itself around a driver specific kconfig option. >> Reason for the feature flag is devices may need a firmware update in >> order for them to work properly. >> >> As for the onus and the cell base station hint though, it is true >> though that the onus option would alone enable the core cell base >> station hints, so the onus option itself would be flipping a switch >> for a feature. I could extend the patch to include a core specific >> base station hint kconfig option, because as you say there is no >> specific switch to select the feature right now for the core. > > I guess the question is -- what does that code really enable, if the > driver doesn't also set the feature flag? If it doesn't mean anything > without the flag I think we don't need the extra core option? Ah -- good question. It'd just be the core. The core can support the base station hint or not but apart from the core we could technically also have a scenario today where perhaps one 802.11 card does support the station hint another does not. It is true that with no 802.11 card present having the core makes no sense but in practice we would, or at the very least we'd have the mac80211_hwsim. So as I designed this I realized we really did have to consider the core getting this Vs a card getting this hint. The core getting the hint would only happen as-is with the onus option enabled, so if we want the onus option only to be a gate to other options then technically the feature would be for the core, while drivers would have the options to enable / disable the same feature given that this requires testing / maybe some changes in the firmware. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
