On Sat, 2012-06-23 at 08:40 -0700, Joe Perches wrote: > > FWIW, I would definitely prefer named rather than bitmap selectors :-) > > (Added Jason and Jim) > > Given it's a debug-only facility, I think bitmap > selectors sufficient, Maybe adding an external > utility to map names to bits would be enough to > not need that feature in the kernel. I guess the real question isn't whether it should be a bitmap or a name or whatever, it's how it's implemented. To allay fears about runtime overhead, I think it would be good to use the jump_label mechanism to implement it -- I do realise that still has runtime overhead for the argument preparation, but still. Looking at the history, it seems that jump labels were at one point used by reverted to fix gcc 3.3, I'm sure that could be resolved? Anyway, the point is that if it uses jump labels then we need some sort of house-keeping structures anyway to be able to enable/disable the right jump labels. And that could easily have a string attached, which would make it easier when working with bug reporters etc. since you don't have to worry about the exact bitmap, you can give them a string (and if it's wrong, there will be a failure rather than silently getting the wrong data) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
