On Fri, 2012-06-22 at 19:18 +0200, Johannes Berg wrote: > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > There are a few things that make the logging and > debugging in mac80211 less useful than it should > be right now: > * a lot of messages should be pr_info, not pr_debug > * wholesale use of pr_debug makes it require *both* > Kconfig and dynamic configuration > * there are still a lot of ifdefs > * the style is very inconsistent, sometimes the > sdata->name is printed in front > Clean up everything, introducing new macros and > separating out the station MLME debugging into > a new Kconfig symbol. I think all the Kconfig debugging options aren't particularly useful. I think you should use a level/mask module debug variable to enable these instead of appearing to try to minimize the size of the objects via individual Kconfig options. I think it'd be better to enable them all the time (or not at all when !DEBUG) and select them for output via the debug level. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
