Search Linux Wireless

Re: [PATCH 4/6] mac80211: clean up debugging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2012-06-23 at 15:04 +0200, Johannes Berg wrote:
> On Sat, 2012-06-23 at 01:02 -0700, Joe Perches wrote:
> 
> > I think all the Kconfig debugging options aren't
> > particularly useful.
> > 
> > I think you should use a level/mask module debug
> > variable to enable these instead of appearing to try
> > to minimize the size of the objects via individual
> > Kconfig options.
> > 
> > I think it'd be better to enable them all the time
> > (or not at all when !DEBUG) and select them for output
> > via the debug level.
> 
> I agree, but I don't want to switch twice. Once pr_debug() has dynamic
> sub-selector capabilities, I'll use it here.
> 
> FWIW, I would definitely prefer named rather than bitmap selectors :-)

(Added Jason and Jim)

Given it's a debug-only facility, I think bitmap
selectors sufficient, Maybe adding an external
utility to map names to bits would be enough to
not need that feature in the kernel.

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux