2012/5/25 Arik Nemtsov <arik@xxxxxxxxxx>: > On Thu, May 24, 2012 at 9:39 AM, Kalle Valo <kvalo@xxxxxxxxxx> wrote: >> Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> writes: >> >>> 2012/5/24 Arik Nemtsov <arik@xxxxxxxxxx>: >>> >>>> Maybe you can offer a better solution? >>>> >>> >>> I am not sure this is better. >>> We do this litte bit different. >>> So disable all ACs by default in mac80211. >>> >>> Next we are using wpa_supplicant: >>> p2p_set client_apsd - and pass required params via nl80211 to mac80211. >>> So, we could decide which ACs set. >>> Reassoc from supplicat is required after that. >> >> I was also thinking of something similar: >> >> Be concervative in mac80211 and only enable U-APSD for VO, just like >> Arik was planning to do only for wl12xx. And then add a userspace >> interface for making it possible to control this and enable/disable >> classes individually. >> >> Or do we already have a user space interface for that? > > Well I'm fine with hard-coding it in mac80211 to be VO only. > > Are we sure there are real use-cases for changing this dynamically? > One would have to find out the AP is "bad" (how?), change the queues > and then re-associate. > That's why I this user-space is an overkill. But if the consensus here > is that user space is preferred, I can live with that too. > > Janusz - It seems driver_nl80211.c doesn't really pass down the > "uapsd" parameter to kernel, and consequently mac80211 doesn't get it. > Are you working with a non-cfg80211 based driver? Or maybe you have an > internal patch to fix this? > Btw, it seems the "uapsd" param can be set via the regular wpa_s > control interface, not only in p2p mode. It's not hard to enable this > from user space as well (and maybe add it to the config file). > Yes, we are using cfg80211/mac80211 and have a patch for that. But this is for old-compat so I think this should be rewritten for new one, while WMM and MAX_SP attr was added in meantime... Question is if this is best interface for application that required UAPSD? For Android it could be fine, but for linux I am not sure. Maybe iw param should be added? BR Janusz -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
