Hi, On Wed, May 23, 2012 at 3:55 PM, Tobias Diedrich <ranma+openwrt@xxxxxxxxxxxx> wrote: > Helmut Schaa wrote: >> On Tue, May 22, 2012 at 10:58 PM, Tobias Diedrich >> <ranma+openwrt@xxxxxxxxxxxx> wrote: >> > Helmut Schaa wrote: >> >> On Fri, May 18, 2012 at 1:04 AM, Tobias Diedrich >> >> <ranma+openwrt@xxxxxxxxxxxx> wrote: >> >> > rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER >> >> > respectively, similar to how it is already done in rt2[45]00pci.c >> >> > >> >> > rt2800lib.c doesn't initialize max_power and thus after >> >> > http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next.git;a=commitdiff;h=eccc068e8e84c8fe997115629925e0422a98e4de >> >> > was applied txpower is limited to 0 for these devices. >> >> > >> >> > This should be the proper fix compared to the net/wireless/reg.c >> >> > hack in http://patchwork.openwrt.org/patch/2165/ >> >> >> >> Btw. Tobias, did this affect the real tx power of the device at all or >> >> is this just >> >> a cosmetic issue? >> > >> > Hmm, apparently setting txpower has no effect? >> > Is it not implemented in the driver? >> >> It is, but only for devices with correct tx power limit in the eeprom. > > Why? Please read [1] for a detailed explanation. > Lowering the tx power should never be an issue, right? Yes but only on by percentage since we don't know the tx power the device was calibrated for. > Or are you saying I'm stuck with 0dBm txpower? No, your stuck with the tx power the device was calibrated for by the manufacturer, and the manufacturer did not intend to allow users to program arbitrary tx power values (in terms of dBm or mW) into the hw. So, your device might be calibrated to let's say 18dBm but the device doesn't provide this information to the driver at all. Hence, we cannot apply a tx power of 16dBm to the device. We could however reduce the real tx power by for example 50% (= -3dBm) but still we don't know the resulting discrete value. We only know we reduced the tx power by 3dBm. > That would be an issue by itself. > Why not use min(hw defaults, regulatory limits) as maximum if there is > no limit in the eeprom? See above and [1]. > Do I have to add an eeprom fixup that will insert valid txpower > limit bytes as an additional step after the eeprom extraction from flash > to make this work? If you know the tx power limit your device is calibrated for you could actually do this. However, I wouldn't suggest to do that ... Helmut [1] http://www.spinics.net/lists/linux-wireless/msg90718.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
